fix: Remove unsafe uses of from_raw_parts from crc32 and murmur hash functions #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Jun 11, 2024
Comment on lines
-48
to
-49
| let data_bytes_64 = | ||
| std::slice::from_raw_parts(&data_bytes[0..len_64] as *const [u8] as *const u64, len / 8); |
There was a problem hiding this comment.
This violates a precondition for from_raw_parts because data_bytes is not guaranteed to be correctly aligned for u64.
andygrove
commented
Jun 11, 2024
Comment on lines
-109
to
-112
| let bytes_u32: &[u32] = std::slice::from_raw_parts( | ||
| &bytes[0..num_words * u32_num_bytes] as *const [u8] as *const u32, | ||
| num_words, | ||
| ); |
There was a problem hiding this comment.
This violates a precondition for from_raw_parts because bytes is not guaranteed to be correctly aligned for u32.
|
Moving to draft until I have criterion benchmarks in place |
|
I found out that none of this code is actually used in Comet, so I am deleting it in #561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #507
Rationale for this change
Remove unsafe uses of from_raw_parts. This code fails in a debug assertion when we upgrade to Rust 1.78.
This fix is copied from #546
What changes are included in this PR?
How are these changes tested?