chore: Add CometEvalMode enum to replace string literals #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes were originally part of #509 but it looks like we won't be merging that one for some time |
kazuyukitanimura
approved these changes
Jun 7, 2024
Comment on lines
31
to
36
| def unhexSerde(unhex: Unhex): (Expression, Expression) = { | ||
| (unhex.child, Literal(unhex.failOnError)) | ||
| } | ||
|
|
||
| def evalMode(c: Cast): CometEvalMode.Value = | ||
| CometEvalModeUtil.fromSparkEvalMode(c.evalMode) |
There was a problem hiding this comment.
nit: it seems to be that we can keep it as protected instead of changing to public?
Also evalMode can be protected?
There was a problem hiding this comment.
That was an unintenional change. I will revert.
There was a problem hiding this comment.
@kazuyukitanimura I made these methods protected in all shim versions for consistency
viirya
approved these changes
Jun 7, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* Add CometEvalMode enum * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Code cleanup.
What changes are included in this PR?
CometEvalModeHow are these changes tested?
Existing tests