fix: Fix integer overflow in date_parser #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The date_parser was introduced in apache#383 and is mostly a direct port of code in Spark. Since the code uses the JVM it has defined integer overflow as wrapping. The proposed fixed is to use std::num::Wrapping to get the same wrapping behavior in rust. The overflown value will still be disgarded in a later check that uses `current_segment_digits` so allowing the overflow does not lead to correctness issues. This resolves one of the overflows discussed in apache#481
eejbyfeldt
changed the title
andygrove
reviewed
Jun 6, 2024
Comment on lines
+1840
to
+1841
| // Overflows i32 | ||
| Some("-4607172990231812908"), |
andygrove
reviewed
Jun 6, 2024
| @@ -19,6 +19,7 @@ use std::{ | |||
| any::Any, | |||
| fmt::{Debug, Display, Formatter}, | |||
| hash::{Hash, Hasher}, | |||
| num::Wrapping, | |||
There was a problem hiding this comment.
I wasn't aware of Wrapping. TIL.
There was a problem hiding this comment.
Wonder if this is also faster since there is no overflow check?
There was a problem hiding this comment.
I think we usually use some methods like wrapping_add, etc.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=============================================
+ Coverage 34.23% 54.68% +20.45%
+ Complexity 803 795 -8
=============================================
Files 105 102 -3
Lines 38483 9688 -28795
Branches 8560 1845 -6715
=============================================
- Hits 13173 5298 -7875
+ Misses 22555 3433 -19122
+ Partials 2755 957 -1798 ☔ View full report in Codecov by Sentry. |
parthchandra
approved these changes
Jun 6, 2024
| @@ -19,6 +19,7 @@ use std::{ | |||
| any::Any, | |||
| fmt::{Debug, Display, Formatter}, | |||
| hash::{Hash, Hasher}, | |||
| num::Wrapping, | |||
There was a problem hiding this comment.
Wonder if this is also faster since there is no overflow check?
viirya
changed the title
andygrove
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
LGTM. Thanks @eejbyfeldt.
Thanks for the review @parthchandra
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
The date_parser was introduced in apache#383 and is mostly a direct port of code in Spark. Since the code uses the JVM it has defined integer overflow as wrapping. The proposed fixed is to use std::num::Wrapping to get the same wrapping behavior in rust. The overflown value will still be disgarded in a later check that uses `current_segment_digits` so allowing the overflow does not lead to correctness issues. This resolves one of the overflows discussed in apache#481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This resolves one of the overflows discussed in #481
Rationale for this change
The date_parser was introduced in #383 and is mostly a direct port of code in Spark. In Spark the code uses Scala which has defined integer overflow as two's complement wrapping.
What changes are included in this PR?
The proposed fixed is to use
std::num::Wrappingto get the same wrapping behavior in rust. The overflown value will still be rejected in a later check that usescurrent_segment_digitsso allowing the overflow does not lead to correctness issues.How are these changes tested?
New and existing unit tests.