Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update plan stability for Spark 4.0 #527

Closed
wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 6, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Fixing broken CI pipelines.

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Member Author

viirya commented Jun 6, 2024

The plan stability results of Spark 4.0 is changed. It causes current CI pipelines failures.

@viirya
Copy link
Member Author

viirya commented Jun 6, 2024

: +- CometFilter (28)
: +- * Project (30)
: +- * Filter (29)
: +- * ColumnarToRow (28)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm do you know why CometFilter is no longer activated by any chance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. But just want to restore CI as soon as possible. We can investigate it later.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.22%. Comparing base (7ab37eb) to head (19ba0c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #527      +/-   ##
============================================
- Coverage     34.23%   34.22%   -0.01%     
  Complexity      803      803              
============================================
  Files           105      105              
  Lines         38483    38483              
  Branches       8560     8560              
============================================
- Hits          13173    13171       -2     
- Misses        22555    22556       +1     
- Partials       2755     2756       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya
Copy link
Member Author

viirya commented Jun 6, 2024

I guess that with #526, we don't need to update the plan stability.

@viirya viirya closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants