docs: changes in documentation #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update tuning section about the compatibility of Shuffle and Spark AQE - Add `release-nogit` for building on an isolated environments - Update docs in the section about an installation process On branch docs-tuning-section-update Changes to be committed: modified: Makefile modified: docs/source/user-guide/installation.md modified: docs/source/user-guide/tuning.md
|
The CI failures with Spark 4 can be fixed by merging latest from main branch |
|
Please ignore. I found the issue and was my error.
|
andygrove
approved these changes
Jun 5, 2024
viirya
reviewed
Jun 5, 2024
| @@ -39,6 +39,8 @@ It must be set before the Spark context is created. You can enable or disable Co | |||
| at runtime by setting `spark.comet.exec.shuffle.enabled` to `true` or `false`. | |||
| Once it is disabled, Comet will fallback to the default Spark shuffle manager. | |||
|
|
|||
| > **_NOTE:_** At the moment Comet Shuffle is not compatible with Spark AQE partition coalesce. To disable set `spark.sql.adaptive.coalescePartitions.enabled` to `false`. | |||
viirya
approved these changes
Jun 5, 2024
kazuyukitanimura
approved these changes
Jun 5, 2024
|
Thank you @SemyonSinchenko @andygrove @viirya merged |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
## Which issue does this PR close? Closes apache#503 Closes apache#191 ## Rationale for this change 1. Provide a way to build Comet from the source on an isolated environments with an access to github.com 2. Update documentation in part, related to compatibility of Spark AQE and Comet Shuffle ## What changes are included in this PR? - Update tuning section about the compatibility of Shuffle and Spark AQE - Add `release-nogit` for building on an isolated environments - Update docs in the section about an installation process Changes to be committed: modified: Makefile modified: docs/source/user-guide/installation.md modified: docs/source/user-guide/tuning.md ## How are these changes tested? I run both `make release` and `make release-nogit`. The first one created properties file in `common/target/classes` but the second did not. The flag `-Dmaven.gitcommitid.skip=true` is described in [this comment](git-commit-id/git-commit-id-maven-plugin#392 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #503
Closes #191
Rationale for this change
What changes are included in this PR?
release-nogitfor building on an isolated environmentsChanges to be committed:
modified: Makefile
modified: docs/source/user-guide/installation.md
modified: docs/source/user-guide/tuning.md
How are these changes tested?
I run both
make releaseandmake release-nogit. The first one created properties file incommon/target/classesbut the second did not. The flag-Dmaven.gitcommitid.skip=trueis described in this comment.