feat: Upgrade to jni-rs 0.21
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR upgrades `jni-rs` from 0.19 to 0.21. There are many API changes between the two versions and hence many places need to be updated as well in the repo. Most notably, many method calls in `jni-rs` now requires a `&mut JNIEnv` as parameter, while it used to be `&JNIEnv`.
viirya
approved these changes
Feb 20, 2024
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #49.
Rationale for this change
Comet currently use
jni-rs0.19 which is a bit out-dated. The latest version0.21.xprovides more improvements including updated safety, better JVM handling, less data copying, etc. On the other hand, it also introduced many API changes. In the long term, we should update to0.21+ to get continuous improvements fromjni-rs.What changes are included in this PR?
This PR upgrades
jni-rsfrom 0.19 to 0.21. There are many API changes between the two versions and hence many places need to be updated as well in the repo.Most notably, many method calls in
jni-rsnow requires a&mut JNIEnvas parameter, while it used to be&JNIEnv.How are these changes tested?
Existing tests.