Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix ClassNotFoundException for Hive tests #499

Merged
merged 1 commit into from
May 31, 2024
Merged

test: fix ClassNotFoundException for Hive tests #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/diffs/3.4.2.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2526,7 +2526,7 @@ index 07361cfdce9..25b0dc3ef7e 100644
+ val v = System.getenv("ENABLE_COMET")
+ if (v != null && v.toBoolean) {
+ conf
+ .set("spark.sql.extensions", "org.apache.spark.CometSparkSessionExtensions")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm? Is current CI broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it failed loading the class and falling back to Spark. So we are not testing Comet for Hive :(

+ .set("spark.sql.extensions", "org.apache.comet.CometSparkSessionExtensions")
+ .set("spark.comet.enabled", "true")
+
+ val v = System.getenv("ENABLE_COMET_SCAN_ONLY")
Expand Down
2 changes: 1 addition & 1 deletion dev/diffs/3.4.3.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2535,7 +2535,7 @@ index 07361cfdce9..25b0dc3ef7e 100644
+ val v = System.getenv("ENABLE_COMET")
+ if (v != null && v.toBoolean) {
+ conf
+ .set("spark.sql.extensions", "org.apache.spark.CometSparkSessionExtensions")
+ .set("spark.sql.extensions", "org.apache.comet.CometSparkSessionExtensions")
+ .set("spark.comet.enabled", "true")
+
+ val v = System.getenv("ENABLE_COMET_SCAN_ONLY")
Expand Down
Loading