Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reuse previous CometDictionary Java arrays #489

Merged
merged 1 commit into from
May 28, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented May 28, 2024

Which issue does this PR close?

Closes #488.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI

@viirya
Copy link
Member Author

viirya commented May 28, 2024

cc @andygrove too

@viirya
Copy link
Member Author

viirya commented May 28, 2024

Thank you @kazuyukitanimura

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@viirya viirya merged commit ee15460 into apache:main May 28, 2024
44 checks passed
@viirya
Copy link
Member Author

viirya commented May 28, 2024

Merged. Thanks @andygrove @kazuyukitanimura

@viirya viirya deleted the reuse_copied_dict_values branch May 28, 2024 20:50
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse previous CometDictionary Java arrays
3 participants