build: Fix mvn cache for containerized runners #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchao
changed the title
advancedxy
force-pushed
the
fix_mvn_cache
branch
from
1aabed5 to
6b13f67
Compare
advancedxy
commented
Feb 20, 2024
| key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} | ||
| path: | | ||
| ~/.m2/repository | ||
| /root/.m2/repository |
There was a problem hiding this comment.
for container users, which is root.
| restore-keys: | | ||
| ${{ runner.os }}-maven- | ||
| ${{ runner.os }}-java-maven- |
There was a problem hiding this comment.
added java and rust to distinguish each other so that they don't interfere
|
|
||
| - name: Run Maven compile | ||
| shell: bash | ||
| run: | | ||
| ./mvnw compile test-compile scalafix:scalafix -Psemanticdb | ||
| ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb |
There was a problem hiding this comment.
-B: batch mode. Suppresses download progress bar.
|
cc @sunchao |
viirya
approved these changes
Feb 20, 2024
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #33 .
Rationale for this change
Fix maven cache issues
What changes are included in this PR?
Modify github action files
How are these changes tested?
Verified in the CI runs.
Others CI runs are also cached: https://github.com/apache/arrow-datafusion-comet/actions/runs/7973418479/job/21767221655?pr=48