Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement ANSI support for UnaryMinus #471

Merged
merged 24 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
21e4629
checking for invalid inputs for unary minus
vaibhawvipul May 25, 2024
6dac6b1
adding eval mode to expressions and proto message
vaibhawvipul May 26, 2024
546b5e8
extending evaluate function for negative expression
vaibhawvipul May 26, 2024
4d54a12
remove print statements
vaibhawvipul May 26, 2024
8395775
fix format errors
vaibhawvipul May 26, 2024
ffacb98
removing units
vaibhawvipul May 26, 2024
8635451
fix clippy errors
vaibhawvipul May 27, 2024
9675562
expect instead of unwrap, map_err instead of match and removing Float16
vaibhawvipul May 27, 2024
a55deab
adding test case for unary negative integer overflow
vaibhawvipul May 28, 2024
e3d1058
added a function to make the code more readable
vaibhawvipul May 28, 2024
dcd1686
adding comet sql ansi config
vaibhawvipul May 28, 2024
1b345fd
using withTempDir and checkSparkAnswerAndOperator
vaibhawvipul May 28, 2024
6c75611
adding macros to improve code readability
vaibhawvipul May 29, 2024
ed0574f
using withParquetTable
vaibhawvipul May 29, 2024
b4e2380
adding scalar tests
vaibhawvipul May 29, 2024
1327deb
adding more test cases and bug fix
vaibhawvipul May 30, 2024
c39dd58
using failonerror and removing eval_mode
vaibhawvipul May 30, 2024
10f64d6
bug fix
vaibhawvipul May 31, 2024
7a8fd38
removing checks for float64 and monthdaynano
vaibhawvipul May 31, 2024
178345a
removing checks of float and monthday nano
vaibhawvipul May 31, 2024
ec4c23f
adding checks while evalute bounds
vaibhawvipul May 31, 2024
24c48ac
IntervalDayTime splitting i64 and then checking
vaibhawvipul Jun 1, 2024
08840f2
Adding interval test
vaibhawvipul Jun 1, 2024
9973306
fix ci errors
vaibhawvipul Jun 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ pub enum CometError {
to_type: String,
},

#[error("[ARITHMETIC_OVERFLOW] {from_type} overflow. If necessary set \"spark.sql.ansi.enabled\" to \"true\" to bypass this error.")]
ArithmeticOverflow {
from_type: String,
},

#[error(transparent)]
Arrow {
#[from]
Expand Down
1 change: 1 addition & 0 deletions core/src/execution/datafusion/expressions/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,4 @@ pub mod sum_decimal;
pub mod temporal;
mod utils;
pub mod variance;
pub mod negative;
Loading
Loading