Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Generate the supported Spark builtin expression list into MD file #455

Merged
merged 21 commits into from
Jun 5, 2024
Merged

Minor: Generate the supported Spark builtin expression list into MD file #455

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c98d690
Coverage: Add a manual test for DF supporting Spark expressions directly
comphead Apr 26, 2024
91ce331
Update spark/src/test/scala/org/apache/comet/CometExpressionCoverageS…
comphead May 9, 2024
91bdc82
Coverage: Add a manual test for DF supporting Spark expressions directly
comphead May 10, 2024
2c97b53
Coverage: Add a manual test for DF supporting Spark expressions directly
comphead May 10, 2024
5cac234
Coverage: Add a manual test for DF supporting Spark expressions directly
comphead May 10, 2024
41e196e
fmt
comphead May 10, 2024
29648a2
fmt
comphead May 20, 2024
b4ac6e5
fmt
comphead May 20, 2024
9cd18b1
fmt
comphead May 20, 2024
e305f36
minor: Generate supported spark builtin expression list into user rea…
comphead May 21, 2024
da1af59
avoid spark skip comet for literals
comphead May 24, 2024
59e8e78
rm not related change
comphead May 24, 2024
ce0d82e
uncomment tests
comphead May 28, 2024
a014192
uncomment tests
comphead May 28, 2024
aa051a6
fmt
comphead May 28, 2024
c82f271
fmt
comphead May 28, 2024
42ba078
fix some tests
comphead May 30, 2024
848e106
fix some tests
comphead May 30, 2024
ec885d6
Update docs/source/user-guide/overview.md
comphead Jun 4, 2024
b5817f4
rm some out of roadmap funcs
comphead Jun 5, 2024
e8f3b77
Merge remote-tracking branch 'origin/dev' into dev
comphead Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/user-guide/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Comet aims to support:
- a native Parquet implementation, including both reader and writer
- full implementation of Spark operators, including
Filter/Project/Aggregation/Join/Exchange etc.
- full implementation of Spark built-in expressions
- [full implementation](../../../docs/spark_expressions_support.md) of Spark built-in expressions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't build correctly:

/Users/andy/git/apache/datafusion-comet/docs/temp/user-guide/overview.md:32: WARNING: Unknown source document '../spark_expressions_support' [myst.xref_missing]

Let's revert this change for this PR and handle where we publish (user guide vs contributor guide) in a follow-up PR.

comphead marked this conversation as resolved.
Show resolved Hide resolved
- a UDF framework for users to migrate their existing UDF to native

## Architecture
Expand Down
Loading
Loading