build: Support built with java 1.8 #45
Conversation
| @@ -76,7 +76,7 @@ object GenTPCHData { | |||
| // Generate data | |||
| // Since dbgen may uses stdout to output the data, tables.genData needs to run table by table | |||
| val tableNames = | |||
| if (config.tableFilter.isBlank) tables.tables.map(_.name) else Seq(config.tableFilter) | |||
| if (config.tableFilter.trim.isEmpty) tables.tables.map(_.name) else Seq(config.tableFilter) | |||
There was a problem hiding this comment.
java8 compatible.
There was a problem hiding this comment.
How about org.apache.commons.lang3.StringUtils.isBlank?
There was a problem hiding this comment.
trim.isBlank is sufficient. I don't think we should use StringUtils.
There was a problem hiding this comment.
In general I would avoid using apache commons if the java standard library has to way to achieve the same. Unless of course there is a measurable performance gain :).
sunchao
changed the title
advancedxy
force-pushed
the
build_with_jdk1.8
branch
from
4a8f3ea to
1e69521
Compare
|
CI passes, please let me if there's any other issues to be addressed. |
advancedxy
force-pushed
the
build_with_jdk1.8
branch
from
be5edb6 to
0402d67
Compare
advancedxy
force-pushed
the
build_with_jdk1.8
branch
from
0402d67 to
92c1ef2
Compare
| runs-on: macos-14 | ||
| env: | ||
| JAVA_VERSION: ${{ matrix.java_version == 8 && '1.8' || format('{0}', matrix.java_version) }} |
There was a problem hiding this comment.
This syntax matrix.java_version == 8 && '1.8' looks weird. It is evaluated to '1.8'?
There was a problem hiding this comment.
Yes, see this example: https://docs.github.com/en/actions/learn-github-actions/expressions#example
And also the actual log:
Co-authored-by: Liang-Chi Hsieh <[email protected]>
Which issue does this PR close?
Closes #43
Rationale for this change
Add support for java 1.8
What changes are included in this PR?
io.github.git-commit-idto 4.9.9 to be compatible with java 1.8How are these changes tested?
updated ci runs.