fix: fix CometNativeExec.doCanonicalize for ReusedExchangeExec #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
fix_broadcast_reuse2
branch
from
472c37f to
32fd8be
Compare
viirya
force-pushed
the
fix_broadcast_reuse2
branch
from
32fd8be to
ebcf14c
Compare
viirya
commented
May 19, 2024
| : +- Exchange (72) | ||
| : +- * HashAggregate (71) | ||
| : +- * HashAggregate (70) | ||
| : +- ReusedExchange (69) |
There was a problem hiding this comment.
After this fix, we get more ReusedExchange in tpcds query plans.
|
Merged. Thanks @sunchao |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #448.
Rationale for this change
What changes are included in this PR?
How are these changes tested?