fix: Reuse CometBroadcastExchangeExec with Spark ReuseExchangeAndSubquery rule #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=========================================
Coverage 34.17% 34.17%
Complexity 850 850
=========================================
Files 116 116
Lines 38547 38552 +5
Branches 8523 8524 +1
=========================================
+ Hits 13172 13176 +4
- Misses 22609 22610 +1
Partials 2766 2766 ☔ View full report in Codecov by Sentry. |
viirya
force-pushed
the
fix_broadcast_reuse
branch
from
c41c097 to
67acabc
Compare
viirya
commented
May 17, 2024
viirya
force-pushed
the
fix_broadcast_reuse
branch
from
67acabc to
4e174d2
Compare
kazuyukitanimura
approved these changes
May 18, 2024
| case plan if plan.children.exists(_.isInstanceOf[BroadcastExchangeExec]) => | ||
| val newChildren = plan.children.map { | ||
| case b: BroadcastExchangeExec | ||
| if isCometNative(b.child) && | ||
| isCometOperatorEnabled(conf, "broadcastExchangeExec") => | ||
| isCometOperatorEnabled(conf, "broadcastExchangeExec") && | ||
| isSpark34Plus => // Spark 3.4+ only |
There was a problem hiding this comment.
If BroadcastExchangeExec is only for 3.4+, is isSpark34Plus extra?
There was a problem hiding this comment.
CometBroadcastExchangeExec is only for 3.4+ not BroadcastExchangeExec.
sunchao
approved these changes
May 18, 2024
|
Merged. Thanks @kazuyukitanimura @sunchao |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…uery rule (apache#441) (cherry picked from commit ec8da30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #439.
Rationale for this change
What changes are included in this PR?
How are these changes tested?