docs: Update Spark shell command to include setting additional class path #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
May 15, 2024
comphead
reviewed
May 15, 2024
| $SPARK_HOME/bin/spark-shell \ | ||
| --jars spark/target/comet-spark-spark3.4_2.12-0.1.0-SNAPSHOT.jar \ | ||
| --jars $COMET_JAR \ | ||
| --conf spark.driver.extraClassPath=$COMET_JAR \ |
There was a problem hiding this comment.
do we need extraClassPath? --jars adds to both driver and executor
https://spark.apache.org/docs/latest/configuration.html
spark.jars Comma-separated list of jars to include on the driver and executor classpaths. Globs are allowed.
There was a problem hiding this comment.
Yes, we need to specify extraClassPath to resolve the ClassNotFoundException issues described in #182. This is specific to spark-shell and not needed for spark-submit.
There was a problem hiding this comment.
It seems some difference on handling extra classpaths on the driver and the executors between spark-submit and spark-shell.
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
(cherry picked from commit 5e05626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #182
Rationale for this change
We need to specify additional options when launching Spark shell to avoid
ClassNotFoundExceptionWhat changes are included in this PR?
How are these changes tested?