Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support spark base64 function #420

Closed
wants to merge 3 commits into from

Conversation

leoluan2009
Copy link
Contributor

Which issue does this PR close?

Closes #419 .

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@leoluan2009 leoluan2009 changed the title Support spark base64 function feat: Support spark base64 function May 13, 2024
@leoluan2009
Copy link
Contributor Author

@viirya Help to start CI, thanks

@leoluan2009
Copy link
Contributor Author

@viirya help to start CI and review code, thanks

@viirya
Copy link
Member

viirya commented May 14, 2024

Looks like there are incompatible results compared with Spark.

@leoluan2009
Copy link
Contributor Author

Looks like there are incompatible results compared with Spark.

datafusion use Basic type of base64 scheme while spark use MIME type. After search the source of https://github.com/marshallpierce/rust-base64 which is used by datafusion for base64 function, I found this lib do not support MIME type of base64 scheme, so it may difficult to add Spark-compatible base64/unbase64 function. @viirya do you have some good ideas?

@viirya
Copy link
Member

viirya commented May 15, 2024

Could we find another library supporting that? We can implement custom base64 function in Comet.

@leoluan2009
Copy link
Contributor Author

Could we find another library supporting that? We can implement custom base64 function in Comet.

I will do some research and have a try, thanks

@leoluan2009 leoluan2009 closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support spark base64 function
2 participants