Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make COMET_EXEC_BROADCAST_FORCE_ENABLED internal config #413

Merged
merged 1 commit into from
May 10, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented May 10, 2024

Which issue does this PR close?

Closes #408.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Member Author

viirya commented May 10, 2024

cc @andygrove

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @viirya
should we also modify the text saying this param is internal?

@andygrove
Copy link
Member

lgtm thanks @viirya should we also modify the text saying this param is internal?

I don't think we need to change the description of the config. We just need to make it internal so that it doesn't appear in the public documentation.

@andygrove andygrove merged commit f08fcad into apache:main May 10, 2024
41 checks passed
@viirya
Copy link
Member Author

viirya commented May 10, 2024

I don't think we need to change the description of the config. We just need to make it internal so that it doesn't appear in the public documentation.

Yes, I agreed. Thanks @andygrove @comphead

@viirya viirya deleted the make_broadcast_config_internal branch May 10, 2024 17:42
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: TPC-H q16 failed with "ColumnarToRow does not implement doExecuteBroadcast"
3 participants