fix: newFileScanRDD should not take constructor from custom Spark versions #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workaround for Amazon EMR version: emr-6.15.0 and Spark 3.4.1 custom implementation
viirya
changed the title
viirya
changed the title
viirya
reviewed
May 10, 2024
spark/src/main/spark-3.x/org/apache/comet/shims/ShimCometScanExec.scala
Outdated
Show resolved
Hide resolved
viirya
approved these changes
May 10, 2024
viirya
reviewed
May 10, 2024
spark/src/main/spark-3.x/org/apache/comet/shims/ShimCometScanExec.scala
Outdated
Show resolved
Hide resolved
viirya
changed the title
andygrove
approved these changes
May 18, 2024
|
I take the liberty to commit some suggestions on code comment and style as it is not responded for days. I will merge this once CI passes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
============================================
- Coverage 34.02% 34.02% -0.01%
- Complexity 857 858 +1
============================================
Files 116 116
Lines 38565 38583 +18
Branches 8517 8521 +4
============================================
+ Hits 13120 13126 +6
- Misses 22691 22702 +11
- Partials 2754 2755 +1 ☔ View full report in Codecov by Sentry. |
|
Merged. Thanks @ceppelli @kazuyukitanimura @andygrove |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…sions (apache#412) * [FIX] - workaround for aws emr spark 3.4 workaround for Amazon EMR version: emr-6.15.0 and Spark 3.4.1 custom implementation * Update spark/src/main/spark-3.x/org/apache/comet/shims/ShimCometScanExec.scala * Update spark/src/main/spark-3.x/org/apache/comet/shims/ShimCometScanExec.scala --------- Co-authored-by: Liang-Chi Hsieh <[email protected]> (cherry picked from commit 1f23c18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #411 .
Rationale for this change
the file spark-sql_2.12-3.4.1-amzn-2.jar is a custom version of spark and contains the class org.apache.spark.sql.execution.datasources.FileScanRDD with 2 constructs, one with 6 parameters and the second with 8 parameters. The suggested workaround filters out the custom constructor.
What changes are included in this PR?
How are these changes tested?