Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unknown operator id when explain with formatted mode #410

Merged
merged 2 commits into from
May 13, 2024

Conversation

leoluan2009
Copy link
Contributor

@leoluan2009 leoluan2009 commented May 10, 2024

Which issue does this PR close?

Closes #409 .

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@leoluan2009
Copy link
Contributor Author

@viirya @andygrove Help to start CI

@viirya
Copy link
Member

viirya commented May 10, 2024

Triggered.

@viirya viirya changed the title Fix unkown operator id when explain with formatted mode fix: Fix unkown operator id when explain with formatted mode May 10, 2024
@viirya viirya changed the title fix: Fix unkown operator id when explain with formatted mode fix: Fix unknown operator id when explain with formatted mode May 10, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @leoluan2009
appreciate if you could add the unit test to prevent regression

@leoluan2009
Copy link
Contributor Author

Can anyone help to find why some checks failed and how can I fix. @comphead @viirya

@comphead
Copy link
Contributor

Can anyone help to find why some checks failed and how can I fix. @comphead @viirya

TPCDS plans comparison failed, supposedly because of this change the plan representation changed and now failed when gets compared with static expected plans

@viirya
Copy link
Member

viirya commented May 11, 2024

You need to update plan stability results, including CometTPCDSV1_4_PlanStabilitySuite and CometTPCDSV2_7_PlanStabilitySuite.

@leoluan2009
Copy link
Contributor Author

leoluan2009 commented May 11, 2024

I have update plan stability results, can you help trigger CI? @viirya @comphead

@leoluan2009 leoluan2009 changed the title fix: Fix unknown operator id when explain with formatted mode fix: Unknown operator id when explain with formatted mode May 11, 2024
@leoluan2009
Copy link
Contributor Author

leoluan2009 commented May 11, 2024

Ci failed because of connection timeout:
Connect to repo.maven.apache.org:443 [repo.maven.apache.org/146.75.28.215] failed: connect timed out

@leoluan2009
Copy link
Contributor Author

thanks @leoluan2009 appreciate if you could add the unit test to prevent regression

@comphead can you give me a example? thanks

@viirya
Copy link
Member

viirya commented May 11, 2024

Ci failed because of connection timeout

I will re-trigger failed pipelines.

Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit bc35fa5 into apache:main May 13, 2024
41 checks passed
@viirya
Copy link
Member

viirya commented May 13, 2024

Merged. Thanks @leoluan2009 @parthchandra @comphead

himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
* Fix unkown id for explain with formatted mode

* update plan stability results

(cherry picked from commit bc35fa5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: unkown operator id for CometScanExec
4 participants