feat: Switch to use Rust stable by default #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sunchao , good work! You will probably need to update the following too - |
viirya
reviewed
May 2, 2024
| @@ -1 +1 @@ | |||
| nightly-2023-09-05 | |||
There was a problem hiding this comment.
Hmm, we might have dependencies, e.g., serde, which use nightly rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
There is little reason for Comet to use nightly at the moment. The only feature we needed from nightly is
specializationwhich is used in a few places that are no longer required.This PR removes a few stale structs:
vectorandmutable_vector, which were added during an experiment of implementing Comet's own vector to be used by execution. However, as we've fully moved to use DataFusion, these are no longer needed.With these structs gone, we can now use
stableas the default Rust toolchain for the project.What changes are included in this PR?
How are these changes tested?