doc: Clean up supported JDKs in README #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs until JDK 8 support confirmed
andygrove
reviewed
May 1, 2024
README.md
Outdated
| @@ -63,7 +63,7 @@ Linux, Apple OSX (Intel and M1) | |||
| ## Requirements | |||
|
|
|||
| - Apache Spark 3.2, 3.3, or 3.4 | |||
| - JDK 8 and up | |||
| - JDK 11 and up (JDK 8 should be supported, but development is on JDK 11) | |||
There was a problem hiding this comment.
I think we should say that we only support 8, 11, and 17 rather than say JDK 11 and up. We do not support JDK 21 for example (neither does Spark 3.x).
I think we should recommend 11 for now because Spark 3.2 does not support JDK 17
There was a problem hiding this comment.
I think for sure option is to use supported JDKs with the Spark version you are working on. It is good to have it clean here to reduce confusion.
andygrove
approved these changes
May 1, 2024
viirya
approved these changes
May 1, 2024
|
Thanks @edmondop |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?