feat: Add DeleteColumnReader and PositionColumnReader #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
May 1, 2024
Comment on lines
+42
to
+45
| Native.setPosition(nativeHandle, position, total); | ||
| position += total; | ||
|
|
||
| super.readBatch(total); |
There was a problem hiding this comment.
I'm not familiar with this area of code, but this looks odd to me and maybe just needs a comment to explain. My understanding:
- we set the position to
position - we then increase the
positionbytotal - then we do the read, but shouldn't this be from the original position?
viirya
reviewed
May 1, 2024
| import org.apache.parquet.column.ColumnDescriptor; | ||
| import org.apache.spark.sql.types.DataTypes; | ||
|
|
||
| /** A column reader for reading position column */ |
There was a problem hiding this comment.
Would you like to add some more comment explaining why we have these? Especially they are not used in Comet itself.
There was a problem hiding this comment.
Actually this is common module, and it is odd to have Iceberg code here.
There was a problem hiding this comment.
These are pretty much similar to ConstantColumnReader, so I am thinking of putting them in common.
There was a problem hiding this comment.
I am OK with leave these in Iceberg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Add
DeleteColumnReaderandPositionColumnReaderfor icebergWhat changes are included in this PR?
How are these changes tested?