-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve CometHashJoin statistics #309
feat: Improve CometHashJoin statistics #309
Conversation
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Liang-Chi Hsieh <[email protected]>
CometConf.COMET_EXEC_ENABLED.key -> "true", | ||
CometConf.COMET_EXEC_ALL_OPERATOR_ENABLED.key -> "true") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think these two confs are enabled in CometTestBase
. Not sure if anything special about restating here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, can be removed, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, thank you!
Merged. Thanks @planga82 |
* HashMergeJoin metrics * HashMergeJoin metrics test * Fix test * Fix format * Fix descriptions * Fix imports * Update spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala Co-authored-by: Liang-Chi Hsieh <[email protected]> * delete conf * Fix --------- Co-authored-by: Liang-Chi Hsieh <[email protected]>
Which issue does this PR close?
Closes #308 .
Rationale for this change
Add all statistics HashJoinExec datafusion node provides.
What changes are included in this PR?
All available metrics
How are these changes tested?
Unit testing and manual testing