feat: Support ANSI mode in CAST from String to Bool #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Apr 19, 2024
37 tasks
andygrove
commented
Apr 19, 2024
Comment on lines
123
to
129
| other if ansi_mode => { | ||
| return Err(CometError::CastInvalidValue { | ||
| value: other.to_string(), | ||
| from_type: "STRING".to_string(), | ||
| to_type: "BOOLEAN".to_string(), | ||
| }) | ||
| } |
There was a problem hiding this comment.
This is the actual fix to add ANSI support in this specific cast operation. The rest of the PR is plumbing to pass ANSI mode down into the planner and improving the cast test suite.
edmondop
reviewed
Apr 19, 2024
|
I will need to do some shim work to make this compile with earlier versions of Spark. |
andygrove
commented
Apr 21, 2024
Comment on lines
+154
to
+157
| // We have to workaround https://github.com/apache/datafusion-comet/issues/293 here by | ||
| // removing the "Execution error: " error message prefix that is added by DataFusion | ||
| val cometMessage = actual.getMessage | ||
| .substring("Execution error: ".length) |
There was a problem hiding this comment.
Follow on issue to resolve this: #293
viirya
approved these changes
Apr 22, 2024
|
Thank you @andygrove |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of the epic #286
Rationale for this change
This PR implements ANSI mode for casting string to boolean, and hopefully provides a good example that others can follow when adding ANSI support to other cast operations.
What changes are included in this PR?
cast()andtry_cast()with ANSI enabled and disabledHow are these changes tested?
New/improved tests in CometCastSuite.