Chore: Cleanup how datafusion session config is created #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Apr 19, 2024
core/src/execution/jni_api.rs
Outdated
Comment on lines
219
to
221
| // Get Datafusion configuration from Spark Execution context | ||
| // can be configured in Comet Spark JVM using Spark --conf parameters | ||
| // e.g: spark-shell --conf spark.datafusion.sql_parser.parse_float_as_decimal=true |
There was a problem hiding this comment.
Could you keep this comment? It doesn't related to how the configs are read into session config but a general description what they come from.
There was a problem hiding this comment.
Okay, will add them back
There was a problem hiding this comment.
added them in commit dd573e2
|
Thanks for this PR. I have one comment about keeping original code comment. |
viirya
approved these changes
Apr 19, 2024
andygrove
approved these changes
Apr 19, 2024
sunchao
approved these changes
Apr 20, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Rather than cloning the strings, inserting into map and creating session config from it. The current approach just sets these values manually. This way we avoid creating a few temporary strings and data structures.
What changes are included in this PR?
Reworked the way datafusion session config is created.
How are these changes tested?
Ensured github ci passes in my forked repo.