chore: Change maven group id from org.apache.comet to org.apache.datafusion.comet #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snmvaughan fyi |
|
I don't have strong opinion on this. It does mean, however, if Comet becomes a top-level project in future, we'd do a costly renaming again which could affect users of the library. |
|
Are we planning to rename the package names as well? |
I don't think it is really necessary though, but not a strong opinion. |
|
I am going to backtrack on this and close this issue. If we are clear about the project's goals to one day graduate from the Apache DataFusion project, then I think it is fine to use Thanks for the reviews and feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The Maven group ID of
org.apache.cometimplies that Comet is a top-level Apache project, and this could cause confusion.What changes are included in this PR?
Change the group ID to
org.apache.datafusion.cometto reflect the fact that Comet is a subproject of the Apache DataFusion top-level project (at least, it will be in the next week or so).We should also change the Java package names, but I would prefer that we do this as a separate PR.
How are these changes tested?
Existing tests.