Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update supported expressions #237

Merged
merged 1 commit into from
Mar 31, 2024
Merged

doc: Update supported expressions #237

merged 1 commit into from
Mar 31, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 29, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

We added some more supported expressions. We should update the document.

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Member Author

viirya commented Mar 29, 2024

cc @parthchandra @huaxingao

Copy link
Contributor

@snmvaughan snmvaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxingao
Copy link
Contributor

LGTM

@viirya
Copy link
Member Author

viirya commented Mar 31, 2024

cc @sunchao

@dbtsai
Copy link
Member

dbtsai commented Mar 31, 2024

Is there a document listing unsupported expressions that individuals could potentially work on if they're interested? Thank you.

@viirya
Copy link
Member Author

viirya commented Mar 31, 2024

Is there a document listing unsupported expressions that individuals could potentially work on if they're interested? Thank you.

We don't have such document. Spark expressions are too many so the unsupported list might be very long.

We can probably list some frequently used expressions which are not supported yet.

@viirya
Copy link
Member Author

viirya commented Mar 31, 2024

I created the umbrella ticket #240 to cover these unsupported expressions. I will add some expressions there so the people who are interested can work on.

@viirya viirya merged commit a8dd4ab into apache:main Mar 31, 2024
2 checks passed
@viirya
Copy link
Member Author

viirya commented Mar 31, 2024

Merged. Thanks.

@viirya viirya deleted the update_doc branch March 31, 2024 21:16
snmvaughan pushed a commit to snmvaughan/arrow-datafusion-comet that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants