fix: Include active spiller when computing peak shuffle memory #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
reviewed
Mar 12, 2024
| @@ -257,6 +257,7 @@ private long getMemoryUsage() { | |||
| for (SpillSorter sorter : spillingSorters) { | |||
| totalPageSize += sorter.getMemoryUsage(); | |||
| } | |||
| totalPageSize += activeSpillSorter.getMemoryUsage(); | |||
There was a problem hiding this comment.
[doubt] any ideas for testing it ? whats the max variance this can cause in worst case ? activeSpillSorter is just full ?
There was a problem hiding this comment.
I'm not sure how to test this in a unit test, but this is clearly something missing. In the non-async path, only activeSpillSorter is used for sorting and spilling, and currently getMemoryUsage doesn't take account of it.
viirya
approved these changes
Mar 12, 2024
|
Oh, seems you need to check if it is null. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=========================================
Coverage 33.30% 33.31%
Complexity 767 767
=========================================
Files 107 107
Lines 35372 35375 +3
Branches 7657 7658 +1
=========================================
+ Hits 11782 11784 +2
Misses 21144 21144
- Partials 2446 2447 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We should include
activeSpillerSorterwhen calculating peak shuffle memory. Otherwise, the stats will be inaccurate.What changes are included in this PR?
How are these changes tested?