minor: Make QueryPlanSerde warning log less confusing
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=========================================
Coverage 33.29% 33.29%
Complexity 766 766
=========================================
Files 107 107
Lines 35385 35385
Branches 7658 7658
=========================================
Hits 11781 11781
Misses 21157 21157
Partials 2447 2447 ☔ View full report in Codecov by Sentry. |
sunchao
reviewed
Mar 11, 2024
| @@ -48,7 +48,7 @@ import org.apache.comet.shims.ShimQueryPlanSerde | |||
| */ | |||
| object QueryPlanSerde extends Logging with ShimQueryPlanSerde { | |||
| def emitWarning(reason: String): Unit = { | |||
| logWarning(s"Comet native execution is disabled due to: $reason") | |||
| logWarning(s"Comet native execution: $reason") | |||
There was a problem hiding this comment.
Hmm just wonder why is this better than the original?
There was a problem hiding this comment.
Oh I see (after reading the Github issue).
There was a problem hiding this comment.
Yea, we post the log because one certain expression/operator is not supported. Not all query is not supported. But currently the message looks like Comet native execution is disabled completely.
sunchao
approved these changes
Mar 11, 2024
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #180.
Rationale for this change
What changes are included in this PR?
How are these changes tested?