fix: Aggregation without aggregation expressions should use correct result expressions #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Mar 9, 2024
Comment on lines
+1786
to
+1791
| val attributes = groupingExpressions.map(_.toAttribute) ++ aggregateAttributes | ||
| val resultExprs = resultExpressions.map(exprToProto(_, attributes)) | ||
| if (resultExprs.exists(_.isEmpty)) { | ||
| emitWarning(s"Unsupported result expressions found in: ${resultExpressions}") | ||
| return None | ||
| } |
There was a problem hiding this comment.
Even aggregateExpressions is empty, we still need to assign result expressions. This is the latest bug I found during fixing TPCDS query failures in SortMergeJoin work.
…esult expressions
viirya
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 33.29% 33.29%
Complexity 766 766
=========================================
Files 107 107
Lines 35379 35385 +6
Branches 7657 7658 +1
=========================================
+ Hits 11778 11781 +3
- Misses 21155 21157 +2
- Partials 2446 2447 +1 ☔ View full report in Codecov by Sentry. |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #176.
Rationale for this change
What changes are included in this PR?
How are these changes tested?