-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: attempt to divide by zero error on decimal division #172
Conversation
cc @sunchao |
attempt to divide by zero
error on decimal division
attempt to divide by zero
error on decimal division
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
============================================
+ Coverage 33.27% 33.29% +0.01%
- Complexity 763 766 +3
============================================
Files 105 107 +2
Lines 35373 35379 +6
Branches 7663 7657 -6
============================================
+ Hits 11772 11778 +6
- Misses 21151 21155 +4
+ Partials 2450 2446 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wonder if we need a similar fix for modulo operation
Thanks for review. I think for modulo operation, we don't implement the operation in Comet but delegate to DataFusion? |
Great, thanks for confirming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged. Thanks. |
Which issue does this PR close?
Closes #171.
Rationale for this change
What changes are included in this PR?
How are these changes tested?