chore: Fix warnings in both compiler and test environments #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
commented
Mar 4, 2024
| @@ -517,6 +517,7 @@ public void close() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| @SuppressWarnings("deprecation") | |||
There was a problem hiding this comment.
FileSystem.getAllStatistics is deprecated.
| @@ -99,6 +99,7 @@ const LOG_PATTERN: &str = "{d(%y/%m/%d %H:%M:%S)} {l} {f}: {m}{n}"; | |||
| // Creates a default log4rs config, which logs to console with `INFO` level. | |||
| fn default_logger_config() -> CometResult<Config> { | |||
| let console_append = ConsoleAppender::builder() | |||
| .target(Target::Stderr) | |||
There was a problem hiding this comment.
Logging to stderr, so that surefire will not complain about: Corrupted channel by directly writing to native stream in forked JVM.
| @@ -711,9 +711,9 @@ under the License. | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <version>3.1.0</version> | |||
| <configuration> | |||
| <systemProperties> | |||
| <systemPropertyVariables> | |||
There was a problem hiding this comment.
systemProperties is deprecated.
| @@ -115,7 +115,7 @@ class CometSparkSessionExtensions | |||
| // data source V1 | |||
| case scanExec @ FileSourceScanExec( | |||
| HadoopFsRelation(_, partitionSchema, _, _, _: ParquetFileFormat, _), | |||
| _: Seq[AttributeReference], | |||
| _: Seq[_], | |||
| _: StringType, | ||
| "readSidePadding", | ||
| arguments, | ||
| _, | ||
| true, | ||
| false, | ||
| true) if arguments.size == 2 => | ||
| true) if clz == classOf[CharVarcharCodegenUtils] && arguments.size == 2 => |
There was a problem hiding this comment.
type erasure. Should check clz instead.
| @@ -29,6 +27,8 @@ import org.apache.spark.sql.execution.{ColumnarToRowExec, SparkPlan, UnaryExecNo | |||
| import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics, SQLShuffleReadMetricsReporter, SQLShuffleWriteMetricsReporter} | |||
| import org.apache.spark.sql.vectorized.ColumnarBatch | |||
|
|
|||
| import com.google.common.base.Objects | |||
There was a problem hiding this comment.
It was wrong to use java.util.Objects
| @@ -271,7 +271,7 @@ class CometTPCHQuerySuite extends QueryTest with CometTPCBase with SQLQueryTestH | |||
| } | |||
|
|
|||
| // TODO: remove once Spark 3.2 & 3.3 is no longer supported | |||
| private val shouldRegenerateGoldenFiles: Boolean = | |||
| private def shouldRegenerateGoldenFiles: Boolean = | |||
There was a problem hiding this comment.
forward reference in L227, which is incorrect in runtime.
sunchao
approved these changes
Mar 4, 2024
viirya
approved these changes
Mar 4, 2024
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When build comet locally, I noticed various warnings. Some are compiler warnings, some are test environment warnings.
Related code should be refactored for better code quality
What changes are included in this PR?
Fixes various warning in the compiler and test environments
How are these changes tested?
Manually verify the output of maven test