Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Only trigger PR title checker on pull requests #154

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

sunchao
Copy link
Member

@sunchao sunchao commented Mar 3, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

In #151 we checks PR title for both pull-requests and push events. We should only do it for the former. This is a follow-up to fix the behavior.

What changes are included in this PR?

Fix PR title checker to only trigger on pull requests.

How are these changes tested?

Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@sunchao sunchao marked this pull request as ready for review March 3, 2024 17:20
@sunchao sunchao merged commit 0ad78cd into apache:main Mar 4, 2024
20 checks passed
@sunchao
Copy link
Member Author

sunchao commented Mar 4, 2024

Thanks, merged

@sunchao sunchao deleted the fix branch March 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants