Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Support CI pipelines for Spark 3.2, 3.3 and 3.4 #153

Merged

Conversation

advancedxy
Copy link
Contributor

Which issue does this PR close?

Closes #143.

Rationale for this change

Software quality and makes sure we don't introduce breaking code that breaks lower Spark versions.

What changes are included in this PR?

  1. fix compile and test failures for old Spark versions
  2. modify PR_BUILD.yml to add build and test against Spark 3.2 and 3.3

How are these changes tested?

CI runs.

is_push_event:
- ${{ github.event_name == 'push' }}
exclude: # exclude java 11 for pull_request event
- java_version: 11
is_push_event: false
fail-fast: false
name: ${{ matrix.test-target }} test on ${{ matrix.os }} with java ${{ matrix.java_version }}
name: ${{ matrix.os }}/java ${{ matrix.java_version }}-spark-${{matrix.spark-version}}/${{ matrix.test-target }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it shorter to display the whole lines so that it would be clear.
image

@advancedxy
Copy link
Contributor Author

cc @sunchao @viirya

@advancedxy advancedxy changed the title build: Support cross build ci pipelines for Spark 3.2, 3.3 and 3.4 build: Support CI pipelines for Spark 3.2, 3.3 and 3.4 Mar 2, 2024
@advancedxy advancedxy force-pushed the matrix_gen_for_spark3.2_and_spark3.3 branch from f2ed88b to bc8307b Compare March 3, 2024 01:54
Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sunchao sunchao merged commit a3dd8df into apache:main Mar 3, 2024
20 checks passed
@sunchao
Copy link
Member

sunchao commented Mar 3, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI pipelines for Spark 3.2 and 3.3
2 participants