feat: Make native shuffle compression configurable and respect spark.shuffle.compress
#1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuyukitanimura
approved these changes
Dec 19, 2024
andygrove
changed the title
spark.shuffle.compressspark.shuffle.compress
dharanad
pushed a commit
to dharanad/datafusion-comet
that referenced
this pull request
Jan 1, 2025
….shuffle.compress` (apache#1185) * Make shuffle compression codec and level configurable * remove lz4 references * docs * update comment * clippy * fix benches * clippy * clippy * disable test for miri * remove lz4 reference from proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1123
Rationale for this change
spark.shuffle.compressso that shuffle compression can be disabled (this is mainly to help with performance profiling)Compression Enabled
Compression Disabled
cargo benchNote that this is just the code of encoding and compressing in memory. There is no disk I/O.
What changes are included in this PR?
Add compression configuration to protobuf
How are these changes tested?