test: enabling Spark tests with offHeap requirement #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ("true" != conf.getConfString("spark.memory.offHeap.enabled", "false")) { | ||
| logInfo("Comet extension disabled because spark.memory.offHeap.enabled=false") | ||
| if (!isOffHeapEnabled(conf) && !isTesting) { | ||
| logWarning("Comet extension disabled because spark.memory.offHeap.enabled=false") |
There was a problem hiding this comment.
Should we add this to extended explain info?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
After #1062 We have not running Spark tests for native execution
What changes are included in this PR?
Removed the off heap requirement for testing
How are these changes tested?
Bringing back Spark tests for native execution