-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[comet-parquet-exec] CometNativeScan metrics from ParquetFileMetrics and FileStreamMetrics #1172
base: comet-parquet-exec
Are you sure you want to change the base?
[comet-parquet-exec] CometNativeScan metrics from ParquetFileMetrics and FileStreamMetrics #1172
Conversation
…o CometNativeScanExec.
|
||
override lazy val metrics: Map[String, SQLMetric] = { | ||
CometMetricNode.baselineMetrics(sparkContext) ++ | ||
Map( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have some way of distinguishing between these metrics and those from the current native scan? Perhaps the display string can have a short prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. We need not do this for all operators. This is just so we could distinguish between metrics reported by different scan implementations.
Is the time spent reading the footer actually zero? |
If I do an explain on the native side I see values that are sub-millisecond, which I'm not sure the Spark UI shows by default:
The |
Still confirming if there's a unit mismatch wrt time between Spark elapsed time and native elapsed time. Once I confirm that, I'll mark this okay for review.