feat: Add dictionary binary to shuffle writer #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
dictionary_binary_shuffle
branch
from
bc34bb5 to
7d942b5
Compare
advancedxy
approved these changes
Feb 26, 2024
| DataType::Int8 => string_dict_builder_inner_helper!( | ||
| Int16Type, | ||
| DataType::Int8 => byte_dict_builder_inner_helper!( | ||
| Int8Type, |
There was a problem hiding this comment.
This is a bug fixes? It looks like we may lack some unit test coverage in the rust side.
Maybe we should add more unit tests in the rust side in the follow-up PRs.
There was a problem hiding this comment.
Yea, it is a typo. More test coverage is good. As there are too many combinations, we probably miss some in current test coverage.
| @@ -292,6 +292,12 @@ pub fn create_hashes<'a>( | |||
| DataType::LargeUtf8 => { | |||
| hash_array!(LargeStringArray, col, hashes_buffer); | |||
| } | |||
| DataType::Binary => { | |||
There was a problem hiding this comment.
Just to confirm, this is for equal/hash contract for Spark side's sort operations?
I noticed some error when testing.
There was a problem hiding this comment.
I remember spark_compatible_murmur3_hash is implemented following Spark shuffle's hash function.
advancedxy
approved these changes
Feb 26, 2024
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #114.
Rationale for this change
Native shuffle writer can write dictionary of string but dictionary of binary is not supported. We should add it.
What changes are included in this PR?
Adding the support of dictionary of binary to native shuffle writer.
How are these changes tested?