returning negative ints as empty string earlier

apache · Jun 11, 2024 · ff10fe3 · ff10fe3
1 parent ab0655b
commit ff10fe3
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/core/src/execution/datafusion/expressions/scalar_funcs/chr.rs b/core/src/execution/datafusion/expressions/scalar_funcs/chr.rs
@@ -45,16 +45,14 @@ pub fn chr(args: &[ArrayRef]) -> Result<ArrayRef> {
         .map(|integer: Option<i64>| {
             integer
                 .map(|integer| {
+                    if integer < 0 {
+                        return Ok("".to_string()); // Return empty string for negative integers
+                    }
                     let adjusted_integer = if integer >= 0 { integer % 256 } else { integer };
-
                     match core::char::from_u32(adjusted_integer as u32) {
                         Some(ch) => Ok(ch.to_string()),
                         None => {
-                            if integer < 0 {
-                                Ok("".to_string())
-                            } else {
-                                exec_err!("requested character not compatible for encoding.")
-                            }
+                            exec_err!("requested character not compatible for encoding.")
                         }
                     }
                 })