Skip to content

Commit

Permalink
Disable q72-v2.7
Browse files Browse the repository at this point in the history
  • Loading branch information
viirya committed Jul 9, 2024
1 parent 2f2d94e commit e875d14
Showing 1 changed file with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ import org.apache.comet.CometConf

class CometTPCDSQuerySuite
extends {
override val excludedTpcdsQueries: Set[String] = Set()
// TODO: unknown failure in CI with q72-v2.7 in
// https://github.com/apache/datafusion-comet/pull/613.
val excludedTpcdsV2_7_0Queries: Set[String] = Set("q72-v2.7")

// This is private in `TPCDSBase` and `excludedTpcdsQueries` is private too.
// So we cannot override `excludedTpcdsQueries` to exclude the queries.
val tpcdsAllQueries: Seq[String] = Seq(
"q1",
"q2",
Expand Down Expand Up @@ -112,6 +112,7 @@ class CometTPCDSQuerySuite
"q69",
"q70",
"q71",
// TODO: unknown failure in CI with q72 in https://github.com/apache/datafusion-comet/pull/613.
// "q72",
"q73",
"q74",
Expand Down Expand Up @@ -142,8 +143,10 @@ class CometTPCDSQuerySuite
"q99")

// TODO: enable the 3 queries after fixing the issues #1358.
override val tpcdsQueries: Seq[String] =
tpcdsAllQueries.filterNot(excludedTpcdsQueries.contains)
override val tpcdsQueries: Seq[String] = tpcdsAllQueries

override val tpcdsQueriesV2_7_0: Seq[String] =
super.tpcdsQueriesV2_7_0.filterNot(excludedTpcdsV2_7_0Queries.contains)
}
with CometTPCDSQueryTestSuite
with ShimCometTPCDSQuerySuite {
Expand Down

0 comments on commit e875d14

Please sign in to comment.