Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
andygrove committed Jun 7, 2024
1 parent 3d28857 commit d07d3b9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ version = "0.1.0"
homepage = "https://datafusion.apache.org/comet"
repository = "https://github.com/apache/datafusion-comet"
authors = ["Apache DataFusion <[email protected]>"]
description = "Apache DataFusion Comet: Apache Spark native query execution plugin"
description = "Apache DataFusion Comet: High performance accelerator for Apache Spark"
readme = "README.md"
license = "Apache-2.0"
edition = "2021"
Expand Down
1 change: 0 additions & 1 deletion dev/release/rat_exclude_files.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
core/Cargo.lock
core/testdata/backtrace.txt
core/testdata/stacktrace.txt
dev/copyright/scala-header.txt
docs/spark_builtin_expr_coverage.txt
docs/source/contributor-guide/benchmark-results/**/*.json
rust-toolchain
Expand Down
2 changes: 1 addition & 1 deletion dev/release/run-rat.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ RELEASE_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
# generate the rat report
$RAT $1 > rat.txt
python3 $RELEASE_DIR/check-rat-report.py $RELEASE_DIR/rat_exclude_files.txt rat.txt > filtered_rat.txt
cat filtered_rat.txt
UNAPPROVED=`cat filtered_rat.txt | grep "NOT APPROVED" | wc -l`

if [ "0" -eq "${UNAPPROVED}" ]; then
echo "No unapproved licenses"
else
echo "${UNAPPROVED} unapproved licences. Check rat report: rat.txt"
cat filtered_rat.txt
exit 1
fi
3 changes: 2 additions & 1 deletion dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ test_source_distribution() {
pushd core
RUSTFLAGS="-Ctarget-cpu=native" cargo build --release
popd
./mvnw install -Prelease -DskipTests -P"spark-3.4" -Dmaven.gitcommitid.skip=true
# test with the latest supported version of Spark
./mvnw verify -Prelease -DskipTests -P"spark-3.4" -Dmaven.gitcommitid.skip=true
}

TEST_SUCCESS=no
Expand Down

0 comments on commit d07d3b9

Please sign in to comment.