update benchmark code

apache · Dec 17, 2024 · a317fc5 · a317fc5
1 parent 0c85460
commit a317fc5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/docs/source/user-guide/metrics.md b/docs/source/user-guide/metrics.md
@@ -34,8 +34,8 @@ Set `spark.comet.metrics.detailed=true` to see all available Comet metrics.
 Comet adds some additional metrics:
 
 | Metric                          | Description                                                                               |
-| ------------------------------- | ----------------------------------------------------------------------------------------- |
-| `ipc time`                      | Time to encode batches in IPC format                                                      |
+| ------------------------------- |-------------------------------------------------------------------------------------------|
+| `ipc time`                      | Time to encode batches in IPC format. Includes compression time.                          |
 | `native shuffle time`           | Total time spent in native shuffle writer, excluding the execution time of the input plan |
 | `native shuffle input time`     | Time spend executing the shuffle input plan and fetching batches.                         |
 | `shuffle wall time (inclusive)` | Total time executing the shuffle write, inclusive of executing the input plan.            |

diff --git a/native/core/benches/row_columnar.rs b/native/core/benches/row_columnar.rs
@@ -20,6 +20,7 @@ use comet::execution::shuffle::row::{
     process_sorted_row_partition, SparkUnsafeObject, SparkUnsafeRow,
 };
 use criterion::{criterion_group, criterion_main, Criterion};
+use datafusion::physical_plan::metrics::Time;
 use tempfile::Builder;
 
 const NUM_ROWS: usize = 10000;
@@ -63,6 +64,8 @@ fn benchmark(c: &mut Criterion) {
         let row_size_ptr = row_sizes.as_mut_ptr();
         let schema = vec![ArrowDataType::Int64; NUM_COLS];
 
+        let ipc_time = Time::default();
+
         b.iter(|| {
             let tempfile = Builder::new().tempfile().unwrap();
 
@@ -77,6 +80,7 @@ fn benchmark(c: &mut Criterion) {
                 false,
                 0,
                 None,
+                &ipc_time,
             )
             .unwrap();
         });