fix 4.0 build

apache · Jun 18, 2024 · 9a66671 · 9a66671
1 parent 33b5597
commit 9a66671
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/common/src/main/spark-3.x/org/apache/comet/shims/ShimBatchReader.scala b/common/src/main/spark-3.x/org/apache/comet/shims/ShimBatchReader.scala
@@ -24,7 +24,7 @@ import org.apache.spark.sql.execution.datasources.PartitionedFile
 
 object ShimBatchReader {
 
-  // TODO: remove after dropping Spark 3.2 & 3.3 support and directly call PartitionedFile
+  // TODO: create specific shim per Spark version rather than use reflection
   def newPartitionedFile(partitionValues: InternalRow, file: String): PartitionedFile =
     classOf[PartitionedFile].getDeclaredConstructors
       .map(c =>

diff --git a/pom.xml b/pom.xml
@@ -588,6 +588,7 @@ under the License.
         <shims.majorVerSrc>spark-4.0</shims.majorVerSrc>
         <shims.minorVerSrc>not-needed-yet</shims.minorVerSrc>
         <shims.pre35Src>not-needed</shims.pre35Src>
+        <additional.pre35.test.source>not needed</additional.pre35.test.source>
         <!-- Use jdk17 by default -->
         <java.version>17</java.version>
         <maven.compiler.source>${java.version}</maven.compiler.source>