Skip to content

Commit

Permalink
Add TODO with GitHub issue link.
Browse files Browse the repository at this point in the history
  • Loading branch information
mbutrovich committed Oct 18, 2024
1 parent d41a9d2 commit 6d13890
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -769,9 +769,11 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
val numBitsExpr = exprToProto(numBits, inputs, binding)
val dataType = serializeDataType(bloom_filter.dataType)

// TODO: Support more types
// https://github.com/apache/datafusion-comet/issues/1023
if (childExpr.isDefined &&
child.dataType
.isInstanceOf[LongType] && // Spark 3.4 only supports Long, 3.5+ adds more types.
.isInstanceOf[LongType] &&
numItemsExpr.isDefined &&
numBitsExpr.isDefined &&
dataType.isDefined) {
Expand Down

0 comments on commit 6d13890

Please sign in to comment.