Skip to content

Commit

Permalink
fix ScalarUDFImpl.return_type failure
Browse files Browse the repository at this point in the history
  • Loading branch information
andygrove committed Dec 10, 2024
1 parent 97e2ac3 commit 6a73f62
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 31 deletions.
44 changes: 22 additions & 22 deletions native/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions native/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ resolver = "2"
[workspace.package]
version = "0.5.0"
homepage = "https://datafusion.apache.org/comet"
repository = "https://github.com/apache/datafusion-comet"
repository = "https://github.com/andygrove/datafusion-comet"
authors = ["Apache DataFusion <[email protected]>"]
description = "Apache DataFusion Comet: High performance accelerator for Apache Spark"
readme = "README.md"
Expand All @@ -39,14 +39,14 @@ arrow-buffer = { version = "53.3.0" }
arrow-data = { version = "53.3.0" }
arrow-schema = { version = "53.3.0" }
parquet = { version = "53.3.0", default-features = false, features = ["experimental"] }
datafusion-common = { git = "https://github.com/apache/datafusion.git" }
datafusion = { git = "https://github.com/apache/datafusion.git", default-features = false, features = ["unicode_expressions", "crypto_expressions"] }
datafusion-functions = { git = "https://github.com/apache/datafusion.git", features = ["crypto_expressions"] }
datafusion-functions-nested = { git = "https://github.com/apache/datafusion.git", default-features = false }
datafusion-expr = { git = "https://github.com/apache/datafusion.git", default-features = false }
datafusion-execution = { git = "https://github.com/apache/datafusion.git", default-features = false }
datafusion-physical-plan = { git = "https://github.com/apache/datafusion.git", default-features = false }
datafusion-physical-expr = { git = "https://github.com/apache/datafusion.git", default-features = false }
datafusion-common = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade" }
datafusion = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade", default-features = false, features = ["unicode_expressions", "crypto_expressions"] }
datafusion-functions = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade", features = ["crypto_expressions"] }
datafusion-functions-nested = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade", default-features = false }
datafusion-expr = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade", default-features = false }
datafusion-execution = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade", default-features = false }
datafusion-physical-plan = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade", default-features = false }
datafusion-physical-expr = { git = "https://github.com/andygrove/datafusion.git", branch="comet-upgrade", default-features = false }
datafusion-comet-spark-expr = { path = "spark-expr", version = "0.5.0" }
datafusion-comet-proto = { path = "proto", version = "0.5.0" }
chrono = { version = "0.4", default-features = false, features = ["clock"] }
Expand Down
2 changes: 2 additions & 0 deletions native/core/src/execution/datafusion/planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2021,6 +2021,8 @@ impl PhysicalPlanner {
.coerce_types(&input_expr_types)
.unwrap_or_else(|_| input_expr_types.clone());

// TODO need to call `return_type_from_exprs` instead
#[allow(deprecated)]
let data_type = func.inner().return_type(&coerced_types)?;

(data_type, coerced_types)
Expand Down

0 comments on commit 6a73f62

Please sign in to comment.