Skip to content

Commit

Permalink
Remove TimestampNTZType cast checks for now
Browse files Browse the repository at this point in the history
  • Loading branch information
andygrove committed Apr 30, 2024
1 parent 9acd634 commit 20e4f05
Showing 1 changed file with 2 additions and 28 deletions.
30 changes: 2 additions & 28 deletions spark/src/test/scala/org/apache/comet/CometCastSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
DataTypes.createDecimalType(10, 2),
DataTypes.StringType,
DataTypes.DateType,
DataTypes.TimestampType,
DataTypes.TimestampNTZType)
DataTypes.TimestampType)
// TODO add DataTypes.TimestampNTZType for Spark 3.4 and later
assertTestsExist(supportedTypes, supportedTypes)
}

Expand Down Expand Up @@ -490,10 +490,6 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}
}

ignore("cast StringType to TimestampNTZType") {
// TODO: implement
}

// CAST from date

ignore("cast DateType to BooleanType") {
Expand Down Expand Up @@ -536,10 +532,6 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
// TODO: implement
}

ignore("cast DateType to TimestampNTZType") {
// TODO: implement
}

// CAST from TimestampType

ignore("cast TimestampType to BooleanType") {
Expand Down Expand Up @@ -582,24 +574,6 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
// TODO: implement
}

ignore("cast TimestampType to TimestampNTZType") {
// TODO: implement
}

// CAST from TimestampNTZType

ignore("cast TimestampNTZType to StringType") {
// TODO: implement
}

ignore("cast TimestampNTZType to DateType") {
// TODO: implement
}

ignore("cast TimestampNTZType to TimestampType") {
// TODO: implement
}

private def generateFloats(): DataFrame = {
val r = new Random(0)
val values = Seq(
Expand Down

0 comments on commit 20e4f05

Please sign in to comment.