Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
andygrove committed Jun 19, 2024
1 parent a4db7ac commit 15bcb0b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
os: [macos-13]
java_version: [8, 11, 17]
test-target: [rust, java]
spark-version: ['3.4']
spark-version: ['3.4', '3.5']
scala-version: ['2.12', '2.13']
fail-fast: false
if: github.event_name == 'push'
Expand All @@ -161,7 +161,7 @@ jobs:
matrix:
java_version: [8, 11, 17]
test-target: [rust, java]
spark-version: ['3.4']
spark-version: ['3.4', '3.5']
scala-version: ['2.12', '2.13']
is_push_event:
- ${{ github.event_name == 'push' }}
Expand Down Expand Up @@ -247,7 +247,7 @@ jobs:
matrix:
java_version: [8, 17]
test-target: [java]
spark-version: ['3.3']
spark-version: ['3.3', '3.4']
scala-version: ['2.12', '2.13']
exclude:
- java_version: 8
Expand Down
1 change: 0 additions & 1 deletion docs/source/user-guide/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ The following diagram illustrates the architecture of Comet:

Comet currently supports the following versions of Apache Spark:

- 3.2.x
- 3.3.x
- 3.4.x

Expand Down
4 changes: 0 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,6 @@ under the License.
<slf4j.version>1.7.32</slf4j.version>
<additional.3_4.test.source>not-needed-yet</additional.3_4.test.source>
<shims.minorVerSrc>spark-3.3</shims.minorVerSrc>
<shims.pre35Src>spark-pre-3.5</shims.pre35Src>
</properties>
</profile>

Expand All @@ -548,9 +547,6 @@ under the License.
<scala.version>2.12.17</scala.version>
<spark.version.short>3.4</spark.version.short>
<parquet.version>1.13.1</parquet.version>
<shims.minorVerSrc>spark-3.4</shims.minorVerSrc>
<shims.pre35Src>spark-pre-3.5</shims.pre35Src>
<additional.pre35.test.source>spark-pre-3.5</additional.pre35.test.source>
</properties>
</profile>

Expand Down

0 comments on commit 15bcb0b

Please sign in to comment.