Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IBANValidatorTest - use registry from swift #293

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Improve IBANValidatorTest - use registry from swift #293

merged 1 commit into from
Dec 17, 2024
+225 −124

Conversation

slawekjaranowski
Copy link
Member

  • add iban_registry_v98.txt from swift site
  • use parametrized test

@slawekjaranowski
Improve IBANValidatorTest - use registry from swift
2b2596d 
- add iban_registry_v98.txt from swift site
- use parametrized test
@garydgregory garydgregory merged commit 154f67a into apache:master Dec 17, 2024
7 of 9 checks passed
@slawekjaranowski slawekjaranowski deleted the iban-registry-test branch December 17, 2024 23:14
@garydgregory
Copy link
Member

TY @slawekjaranowski 😊
How soon do you need a release?

@slawekjaranowski
Copy link
Member Author

Hi @garydgregory thanks for asking ...

I would like do https://issues.apache.org/jira/browse/VALIDATOR-497 and https://issues.apache.org/jira/browse/VALIDATOR-496
after it I think release will be ok 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garydgregory garydgregory garydgregory left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @garydgregory