Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to JUnit5 #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

strangelookingnerd
Copy link

This PR aims to migrate all tests to JUnit5.

Migration includes:

  • Using JUnit5 annotations
  • Using Assertions over Assert
  • Remove public modifiers from test classes and methods
  • Clean up assertions (switching expected and actual, simplyifing assertions...)
  • Trivial code cleanup

I validated my changes using mvn verify and noticed that one test failed before and after my changes, others pass just fine.

[ERROR] Failures: 
[ERROR]   DatasetJenaTest>AbstractDatasetTest.testStreamDefaultGraphNameByPattern:704 expected: <null> but was: <<http://example.com/graph1>>

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @strangelookingnerd

Thank you for your PR.

It looks like every line in pom.xml has been edited, and so creates a conflict.

Would you mind resolving this?

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @strangelookingnerd
Same comments as for apache/commons-dbutils#324, especially non-required noisy changes that make the PR bigger and harder to review.
TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants