list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools

[sureshanaparti]

Description

The list hosts API fails with NPE, when any stale entries exists on storage_pool_host_ref for the removed pools. This PR fixes it.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually verified the fix, with entry on storage_pool_host_ref for removed pool.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (175eed2) to head (defb879).
Report is 23 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9852      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
+ Complexity    11203    11200       -3     
============================================
  Files          5404     5404              
  Lines        473423   473423              
  Branches      59987    60194     +207     
============================================
- Hits          71429    71426       -3     
- Misses       394044   394048       +4     
+ Partials       7950     7949       -1     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.80% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11429

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11430

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11699)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44007 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9852-t11699-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	134.44	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	134.45	test_vm_life_cycle.py

[DaanHoogland]

clgtm

[sureshanaparti]

@blueorangutan package

[sureshanaparti]

@blueorangutan package

[rohityadavcloud]

@blueorangutan test

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11526

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11766)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51079 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9852-t11766-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	133.47	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	133.47	test_vm_life_cycle.py

[vishesh92]

clgtm. didn't test.